Allow streamed responses with Ollama tools #904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of https://github.com/ollama/ollama/releases/tag/v0.8.0 Ollama allows streaming responses with tool calls.
Owner
|
Thanks for the PR. The line you changed just removes the check to disable streaming when using tools with Ollama. There is no actual logic in Have you tried testing your change? |
Contributor
Author
|
I don't seem to be getting very consistent streaming with any ollama model with or without tools, unfortunately. I'll try to figure that out and then try to find a bit of time to work on making this actually work. |
Owner
|
@timfel Did you have any luck getting streaming + tools to work with Ollama? |
Contributor
Author
Sorr, no, I did not have much time to try it. Feel free to close. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of https://github.com/ollama/ollama/releases/tag/v0.8.0 Ollama allows streaming responses with tool calls.